DeviceManager: use gala's brightness interface by garaevdi · Pull Request #301 · elementary/panel-power

garaevdi · 2026-07-17T13:00:26Z

Fixes #296
Requires elementary/gala#2916

leolost2605

Works great with elementary/gala#2916 thanks! I left a few comments

leolost2605

A few comments :)

leolost2605 · 2026-09-22T10:14:44Z

+    private void populate_list () {
+        for (int i = 0; i < brightness_manager.get_n_monitors (); i++) {
+            if (i != 0) {
+                list_box.append (new Gtk.Separator (Gtk.Orientation.HORIZONTAL) {


You can just use Gtk.ListBox.show_separators for this

Fixed, but it doesn't quite have the same style as other separators (perhaps fixed in granite-9?)

Hmm maybe even no separators would work? Since it belongs to the same group of controls I think it would make sense to have no separators. @elementary/ux any opinions?

So there would be no warning when we are trying to scroll on top of indicator while there is no suitable monitors with brightness control

leolost2605

A few nits apart from that LGTM :)

leolost2605 · 2026-10-03T20:47:41Z

+/*
+ * Copyright (c) 2011-2018 elementary LLC. (https://elementary.io)
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this program; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street - Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */


You should use the new license header here like you do elsewhere

Suggested change

/*

* Copyright (c) 2011-2018 elementary LLC. (https://elementary.io)

*

* This program is free software; you can redistribute it and/or

* modify it under the terms of the GNU General Public

* License as published by the Free Software Foundation; either

* version 2 of the License, or (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

* General Public License for more details.

*

* You should have received a copy of the GNU General Public

* License along with this program; if not, write to the

* Free Software Foundation, Inc., 51 Franklin Street - Fifth Floor,

* Boston, MA 02110-1301, USA.

*/

/*

* Copyright 2026 elementary, Inc. (https://elementary.io)

* SPDX-License-Identifier: GPL-3.0-or-later

*/

leolost2605 · 2026-10-03T20:48:11Z

+            if (gala_brightness_manager == null) {
+                return false;
+            }
+
+            return true;


Suggested change

if (gala_brightness_manager == null) {

return false;

}

return true;

return gala_brightness_manager != null;

leolost2605 · 2026-10-03T20:48:29Z

+            if (get_n_monitors () <= 0) {
+                return false;
+            }
+
+            return true;


Suggested change

if (get_n_monitors () <= 0) {

return false;

}

return true;

return get_n_monitors () > 0;

leolost2605 · 2026-10-03T20:50:37Z

+        brightness_manager.notify["has-monitors"].connect ((s, p) => {
+            update_device_separator_revealer ();
+        });


Suggested change

brightness_manager.notify["has-monitors"].connect ((s, p) => {

update_device_separator_revealer ();

});

brightness_manager.notify["has-monitors"].connect (update_device_separator_revealer);

leolost2605 · 2026-10-03T20:52:17Z

+/*
+ * Copyright 2011-2021 elementary, Inc. (https://elementary.io)
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this program; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street - Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */


Suggested change

/*

* Copyright 2011-2021 elementary, Inc. (https://elementary.io)

*

* This program is free software; you can redistribute it and/or

* modify it under the terms of the GNU General Public

* License as published by the Free Software Foundation; either

* version 2 of the License, or (at your option) any later version.

*

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

* General Public License for more details.

*

* You should have received a copy of the GNU General Public

* License along with this program; if not, write to the

* Free Software Foundation, Inc., 51 Franklin Street - Fifth Floor,

* Boston, MA 02110-1301, USA.

*/

/*

* Copyright 2026 elementary, Inc. (https://elementary.io)

* SPDX-License-Identifier: GPL-3.0-or-later

*/

leolost2605 · 2026-10-03T20:53:45Z

+        };
+
+        if (index == 0) {
+            monitor_label.set_text (_(@"$(monitor_label.get_text ()) (Primary)"));


Suggested change

monitor_label.set_text (_(@"$(monitor_label.get_text ()) (Primary)"));

monitor_label.set_text (_("%s (Primary)").printf (monitor_label.get_text ()));

leolost2605 · 2026-10-03T20:54:28Z

+            monitor_label.set_text (_(@"$(monitor_label.get_text ()) (Primary)"));
+        }
+
+        brightness_slider = new Gtk.Scale.with_range (Gtk.Orientation.HORIZONTAL, 0, 1, 0.1) {


We usually leave the namespace away if it's not necessary

Suggested change

brightness_slider = new Gtk.Scale.with_range (Gtk.Orientation.HORIZONTAL, 0, 1, 0.1) {

brightness_slider = new Gtk.Scale.with_range (HORIZONTAL, 0, 1, 0.1) {

leolost2605 · 2026-10-03T20:54:40Z

+            width_request = 175
+        };
+
+        var slider_box = new Granite.Box (Gtk.Orientation.VERTICAL, Granite.Box.Spacing.NONE) {


Suggested change

var slider_box = new Granite.Box (Gtk.Orientation.VERTICAL, Granite.Box.Spacing.NONE) {

var slider_box = new Granite.Box (VERTICAL, NONE) {

leolost2605 · 2026-10-03T20:54:50Z

+        slider_box.append (monitor_label);
+        slider_box.append (brightness_slider);
+
+        var box = new Granite.Box (Gtk.Orientation.HORIZONTAL, Granite.Box.Spacing.HALF) {


Suggested change

var box = new Granite.Box (Gtk.Orientation.HORIZONTAL, Granite.Box.Spacing.HALF) {

var box = new Granite.Box (HORIZONTAL, HALF) {

DeviceManager: use gala's brightness interface

96d1856

zeebok requested a review from a team July 25, 2026 16:16

ryonakano added this to OS 9 Jul 28, 2026

ryonakano moved this to In progress in OS 9 Jul 28, 2026

ryonakano moved this from In progress to Needs Review in OS 9 Jul 28, 2026

Merge branch 'main' into gala-brightness-interface

3d34157

flodavid reviewed Aug 30, 2026

View reviewed changes

Comment thread src/Widgets/ScreenBrightness.vala Outdated

garaevdi force-pushed the gala-brightness-interface branch 2 times, most recently from 8ae12b5 to 908399e Compare August 30, 2026 17:28

Update for interface changes

8a12a7c

garaevdi force-pushed the gala-brightness-interface branch from 908399e to 8a12a7c Compare August 30, 2026 17:40

Merge branch 'main' into gala-brightness-interface

29b4e17

leolost2605 requested changes Sep 4, 2026

View reviewed changes

Comment thread src/Services/DeviceManager.vala Outdated

Comment thread src/Widgets/ScreenBrightness.vala Outdated

Comment thread src/Indicator.vala Outdated

Comment thread src/Indicator.vala Outdated

garaevdi and others added 3 commits September 6, 2026 22:04

Adressing comments

3063d97

Tweak appearance a bit

0c4c43c

Merge branch 'main' into gala-brightness-interface

d92efc4

zeebok requested a review from leolost2605 September 21, 2026 05:14

leolost2605 requested changes Sep 22, 2026

View reviewed changes

garaevdi added 2 commits September 24, 2026 23:10

Colapse DBus interface class name

a59d72f

Use correct DBus interface name

074a3c4

garaevdi force-pushed the gala-brightness-interface branch from ceb59d7 to 58955ad Compare September 24, 2026 20:15

leolost2605 requested changes Sep 30, 2026

View reviewed changes

garaevdi added 5 commits October 3, 2026 11:05

Utils: store natural scroll settings internally

3a175c2

BrightnessManager: Simplify init

c385abc

ScreenBrightnessList: use ListBox's separator

ca51f57

BrightnessManager: Separate monitor detection into separate property

b6d92bb

PopoverWidget: Properly hide extra separators

5ff0d1e

garaevdi force-pushed the gala-brightness-interface branch from 58955ad to be83482 Compare October 3, 2026 09:18

garaevdi added 2 commits October 3, 2026 12:29

Indicator: Hide when there is no monitors

10e07ce

ScreenBrighnessRow: Use Granite.Box

cea46cc

garaevdi added 3 commits October 3, 2026 12:29

ScreenBrighnessRow: Avoid using lambdas

956c5d1

ScreenBrightnessRow: Use template string

f5b7db4

Utils: Don't try to change monitor's brightness if there is no monitors

3b4e913

So there would be no warning when we are trying to scroll on top of indicator while there is no suitable monitors with brightness control

garaevdi force-pushed the gala-brightness-interface branch from be83482 to 3b4e913 Compare October 3, 2026 09:30

leolost2605 requested changes Oct 3, 2026

View reviewed changes

	monitor_label.set_text (_(@"$(monitor_label.get_text ()) (Primary)"));
	monitor_label.set_text (_("%s (Primary)").printf (monitor_label.get_text ()));

	brightness_slider = new Gtk.Scale.with_range (Gtk.Orientation.HORIZONTAL, 0, 1, 0.1) {
	brightness_slider = new Gtk.Scale.with_range (HORIZONTAL, 0, 1, 0.1) {

	var slider_box = new Granite.Box (Gtk.Orientation.VERTICAL, Granite.Box.Spacing.NONE) {
	var slider_box = new Granite.Box (VERTICAL, NONE) {

	var box = new Granite.Box (Gtk.Orientation.HORIZONTAL, Granite.Box.Spacing.HALF) {
	var box = new Granite.Box (HORIZONTAL, HALF) {

Conversation

garaevdi commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

leolost2605 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leolost2605 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garaevdi Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leolost2605 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

garaevdi commented Jul 17, 2026 •

edited

Loading

garaevdi Sep 24, 2026 •

edited

Loading