Repository navigation
PopoverManager: DRY and organize current_indicator setter - #734
Open
danirabbit wants to merge 4 commits into
Open
danirabbit wants to merge 4 commits into
danirabbit wants to merge 4 commits into
Conversation
lenemter
force-pushed
the
danirabbit/popovermanager-currentdryorganize
branch
from
October 2, 2026 16:44
4e9fa7f to
2f549f3
Compare
lenemter
requested changes
Oct 2, 2026
lenemter
left a comment
lenemter
left a comment
Member
There was a problem hiding this comment.
The indicators randomly stop opening for me until I reopen Applications menu through via the shortcut
| } | ||
|
|
||
| set { | ||
| // Double close. Shouldn't happen? |
Member
There was a problem hiding this comment.
I don't think this comment is needed
Member
Author
There was a problem hiding this comment.
I thought it was worth explaining why we return here
Member
Author
|
@lenemter that happens to me in main as well. There shouldn't be any logic changes in this branch, just refactoring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unparentin popover close because we do that already incurrent_indicator = null