Repository navigation
Rework focus handling - #740
Merged
Merged
Conversation
danirabbit
approved these changes
Oct 13, 2026
danirabbit
left a comment
danirabbit
left a comment
Member
There was a problem hiding this comment.
Works perfectly! Great job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #710
Fixes #726
Closes #737
Instead of delegating focus handling to
Gtk.Popoverwithautohide = true, handle focus of the whole toplevel surface as Gtk.Popover is bugged and closes by itself for some reason (mutter has some quirks with focus handling for windows with window_type = DOCK, maybe it has something to do with it)