Dk inspect algebra unboxed worklist - #15946
Merged
josevalim merged 3 commits intoSep 26, 2026
Merged
Conversation
fits?/4 and format/4 walked the document through a list of {i, mode, doc}
entries. Every step popped one entry and pushed the rewritten one back,
allocating a 4-word tuple plus a 2-word cons cell for a value consumed
on the very next iteration.
fits?/7 and format/7 now take the head entry unboxed in registers and only
box what stays on the list, so unwrapping intermediate nodes allocates
nothing and a cons allocates one entry instead of two.
The k > w check stays in fits?/4 only: every clause that grows k hands
over to fits?/4, ensuring the guard cannot be skipped.
Assisted-by: Antigravity:Gemini 3.8 Flash
Member
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry the current worklist entry in registers in
Inspect.Algebra.fits?andInspect.Algebra.formatinstead of boxing it back onto the{indent, mode, doc}entry list on every step.doc_nest,doc_color,doc_force,doc_fits) now allocates nothing.doc_cons(x, y)only allocates one entry (fory), passingximmediately in registers.k > w and b?guard remains centralized infits?/4.Benchmarks (Benchee, OTP 29)
Assisted-by: Antigravity:Gemini 3.8 Flash