Repository navigation
Conversation
serverTxRequest held the transaction store's write lock across serverTxCreate, which acquires the connection the responses will ride. When the connection the request arrived on is already gone that is a dial to the Via host, and to a peer that has gone away it lasts the whole connect timeout — under a lock every request the layer receives waits on. The requests queued behind it then time out at their senders, whose closed connections make them the next dials, so the server side does not recover: INVITE forwarding fails at Timer B, REGISTERs go unanswered, and the subscribers those belonged to deregister. Create the transaction unlocked and insert it under the lock, with a retransmission that raced its copy in first settled in the winner's favour. Seen on a 10,000-UE IMS bed: two of four P-CSCFs were down for two hours. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Closing: superseded by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serverTxRequestholds the transaction store's write lock acrossserverTxCreate, which acquires the connection the responses will ride. When the connection the request arrived on is already gone, that is a dial to the Via host — and to a peer that has gone away it lasts the whole connect timeout, under a lock every request the layer receives waits on.The requests queued behind it time out at their senders, whose closed connections make them the next dials, so the server side doesn't recover: INVITE forwarding fails at Timer B, REGISTERs go unanswered, and the subscribers those belonged to deregister.
Create the transaction unlocked and insert it under the lock, settling a retransmission that raced its copy in first in the winner's favour.
Seen on a 10,000-UE IMS bed: two of four proxies were down for two hours.
The test pins a dial open and checks an unrelated request still gets through; it fails on main after 2s.