[CI] Move x86 Windows launcher build job to GitHub Actions - #27606
Merged
Conversation
Move the `build-windows-launcher` job from CircleCI to GitHub Actions (`build-pylauncher-x64`), matching the existing ARM64 launcher build job. Remove `build-windows-launcher` from `.circleci/config.yml` and delete the unused `.circleci/setup_vs2022.bat`.
kripken
reviewed
Aug 25, 2026
| command: $EMSDK_PYTHON tools/maint/create_entry_points.py --exe-files | ||
| - run: | ||
| name: "crossplatform tests" | ||
| command: test/runner.exe core0.test_hello_world |
Member
There was a problem hiding this comment.
I see a test here, but not in the new code - where is it?
Collaborator
Author
There was a problem hiding this comment.
We still build the windows launcher here as part of the windows testing. It is used to run all the windows tests:
emscripten/.circleci/config.yml
Lines 1251 to 1256 in 7ee8fcc
Before we were building it twice in circleci: once as its own job, and once before running all the windows tests.
kripken
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
build-windows-launcherjob from CircleCI to GitHub Actions (build-pylauncher-x64), matching the existing ARM64 launcher build job. Removebuild-windows-launcherfrom.circleci/config.ymland delete the unused.circleci/setup_vs2022.bat.