Skip to content

Mark WASM_BINDGEN as an experimental setting - #27616

Merged
walkingeyerobot merged 3 commits into
emscripten-core:mainfrom
guybedford:wasm-bindgen-experimental
Aug 29, 2026
Merged

Mark WASM_BINDGEN as an experimental setting#27616
walkingeyerobot merged 3 commits into
emscripten-core:mainfrom
guybedford:wasm-bindgen-experimental

Conversation

@guybedford

Copy link
Copy Markdown
Collaborator

This marks -sWASM_BINDGEN as an experimental setting, since the wasm-bindgen integration is still evolving and subject to change.

  • Adds the [experimental] tag in settings.js and an EXPERIMENTAL_SETTINGS entry, so enabling it now emits the standard -Wexperimental diagnostic:
emcc: warning: -sWASM_BINDGEN is experimental and subject to change [-Wexperimental]
  • Regenerates the settings reference docs and adds a ChangeLog entry.

@sbc100

sbc100 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

We might also need to add -Wno-experimental to the tests that use this flag.

@sbc100
sbc100 requested a review from walkingeyerobot August 28, 2026 21:16
@sbc100

sbc100 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@walkingeyerobot I asked guy to add this.. we probably should have done it in the first place.

Are you ok with this?

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but lets wait for @walkingeyerobot before landing

Comment thread ChangeLog.md Outdated
The wasm-bindgen integration is still evolving, so flag -sWASM_BINDGEN
as experimental with the standard -Wexperimental diagnostic, matching
other experimental settings.
@guybedford
guybedford force-pushed the wasm-bindgen-experimental branch from f774f4a to da95cfc Compare August 28, 2026 21:49

@walkingeyerobot walkingeyerobot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@walkingeyerobot
walkingeyerobot merged commit 4897433 into emscripten-core:main Aug 29, 2026
42 checks passed
@guybedford
guybedford deleted the wasm-bindgen-experimental branch August 29, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants