[bootstrap] Honor EMSDK_NODE in bootstrap.py - #27617
Conversation
90b8dda to
d4e27ff
Compare
When `EMSDK_NODE` is present in the environment, prepend its directory to `PATH` before running bootstrap actions. By default, emsdk avoids prepending its own node binary to `PATH` if a system node is already present in `PATH`. However, bootstrap actions (such as `npm ci`) may fail if the system node is an older incompatible version or lacks npm. See: emscripten-core#27614
d4e27ff to
b0c7e62
Compare
|
I don't follow, why are bootstrap actions special? That is, the same reasoning suggests this could help non-bootstrap situations too? |
I tried to explain the comment but maybe its not clear. Non-bootstrap tools get However, we do really want to use the same version of node that we have in the config file when we run |
|
Sorry, the auto-merge landed before you got a change to approve @kripken |
When
EMSDK_NODEis present in the environment, prepend its directory toPATHbefore running bootstrap actions.By default, emsdk avoids prepending its own node binary to
PATHif a system node is already present inPATH. However, bootstrap actions (such asnpm ci) may fail if the system node is an older incompatible version or lacks npm.See: #27614