Repository navigation
Conversation
When a client creates a text_input object after keyboard focus has already been granted, the new instance never received an enter event, causing all subsequent text_input requests to be discarded. Fix by sending enter immediately in add_instance() if a matching focus is already set.
Collaborator
|
代码format 还是有问题， 提交前 先 |
Author
改完本地过了，貌似卡其他地方了。 |
Collaborator
只要提交的这部分代码没问题， 就行， 这个我暂时不合并，你那边 sway 测试没问题了， 我再合进来 |
…ance exists When a client creates a text_input object after keyboard focus has already been granted, the new instance never received an enter event, causing all subsequent text_input requests to be discarded. However, blindly sending enter on every new instance breaks compositors (e.g. sway) where the normal enter flow has already been handled. Fix by only sending enter if no existing instance from the same client has an active serial (serial > 0 indicates the enter→enable→commit flow has already completed normally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client creates a text_input object after keyboard focus has already been granted, the new instance never received an enter event, causing all subsequent text_input requests to be discarded.
Fix by sending enter immediately in add_instance() if a matching focus is already set.
Description
Checklist