Skip to content

Separate component keys from URDF link and joint names - #125

Open
stevenaya wants to merge 1 commit into
enactic:mainfrom
stevenaya:codex/stable-component-keys
Open

stevenaya wants to merge 1 commit into
enactic:mainfrom
stevenaya:codex/stable-component-keys

Conversation

@stevenaya

Copy link
Copy Markdown
Contributor

Component configuration currently uses URDF names as lookup keys. Separate the two so a link or joint can be renamed without changing its configuration references.

Changes

  • Use stable link1…N and joint1…N keys, with an optional topology name for the emitted local name.
  • Resolve final names once in component descriptions and share the maps with link/joint generation, mimic targets, reference frames and mounting.
  • Migrate V2 arm, pinch-gripper and body configuration while preserving emitted names, instance prefixes and model parameters.
  • Keep the ZED adapter's official frame names and update existing test fixtures for key/name separation.

For example, joint1: {name: finger_joint1, ...} is referenced as joint1 in configuration and emitted as <prefix>finger_joint1.

Validation

  • All 27 existing ROS 2 Jazzy tests pass; no test functions or files added.
  • 25 before/after model expansions match, including both robot versions, V2 presets and standalone grippers. Only temporary package-root paths are normalized for comparison.
  • Mesh files and generated example URDFs are unchanged.

Copilot AI balanced review requested due to automatic review settings November 6, 2026 10:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch was successfully deployed

1 active deployment
release — 2996035d Deployed Nov 6, 2026 by stevenaya via Publish #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants