Repository navigation
Fix seqno log spam - #163
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #96
Why
When we remove a prefix, nodes don't immediately drop that prefix and instead wait for it to expire. Resolution attempts result in seqno spam in logs.
How
reconcileRouterState(which is called fromApplyCentralConfig) now explicitly drops the prefixCaveats
This only takes effect after a node fetches the new config. Before it fetches the new config it has no way to tell that the prefix has dropped and will still spam (default node config fetch time is every 10s)
Tests
Tested locally on a setup with 4 connected nodes and dropping a prefix for one node.