Repository navigation
feat: bootstrap central config from node config dist URL on first run - #30
Merged
Merged
Conversation
Owner
|
This is amazing, thanks for the contribution. I’ll review this after work today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the central config is missing and the node config includes a
distsection with url and key, nylon will fetch and save the central config on first run.This was already mentioned in the example/README.md but appearently it wasn’t actually implemented. I find this quite useful for deploying nodes that can "self configure" from a remote bundle without having to manually copy the central config to every node.