Repository navigation
feat: keep deployments quiet in the collapsed notch - #12
Merged
Merged
Conversation
The notch width came from agent activity plus a 140pt reservation for the deployment row, so starting or finishing a build resized and shifted the notch. Width is now derived from agents only, and the deployment becomes a badge in the idle mascot's slot: Vercel's sprite plus a state dot, with no text and no extra width. The indeterminate indicator moves to the expanded list, where there is room for project, repository, commit and author.
The monitor persisted its tracker, so a deployment that finished while the app was closed notified on the next launch. The tracker now starts empty on every run: the first poll is a baseline and only transitions observed while the app runs are announced. Notification permission is also narrowed to the moments worth a banner: the monitor asks an injected policy, and the app answers with the preference, a collapsed notch, and no pending approval.
Update the collapsed-notch rules to match the code (no layout delta, one badge, details on hover) and the notification rule now that the tracker is per run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #11
What and why
max(earWidth, 140)whenever a deployment was active, so starting or finishing a build resized and shifted the notch. Width now comes from agent activity only. The deployment becomes a badge in the idle mascot's slot — Vercel's sprite plus a state dot — costing no extra width and never replacing a working agent's signal (rule 2).Changes
Sources/AgentNotch/UI/NotchRootView.swiftSources/AgentNotch/UI/SessionListView.swiftSources/AgentNotch/Infrastructure/VercelMonitor.swiftshouldNotifypolicy, tracker per run, no persistenceSources/AgentNotch/App/AppDelegate.swiftSources/AgentNotch/Domain/Deployment.swiftCodable; documented baseline behaviourTests/AgentNotchTests/DeploymentTrackerTests.swiftdocs/vercel-notch-ux.md,docs/vercel-deployment-monitoring.mdHow I tested it
swift build -c releasepassespython3 scripts/check-strings.pypasses (89 strings in 3 languages)bash -n bridge/agent-notch-hook scripts/*.shpassesswift testpasses (XCTest suites plus 7 Swift Testing tests)Reviewer notes
vercelTrackerUserDefaultskey is no longer written. Existing values on a user's machine are ignored rather than deleted; say if you prefer a one-line cleanup on launch.isIdleandearAgents, neither of which readsvercel) and by the release build; the repo has no snapshot tests, so it is not pixel-tested.AppDelegate, so it is not unit-tested; the tracker rule it relies on is covered byDeploymentTrackerTests.