Repository navigation
Conversation
The mapping wrote experiment.mode as the constant plan, so EnerPlanET could not ask for a run with fixed sizes. The payload's top-level mode, plan or operate, now becomes experiment.mode; a payload without it stays in plan mode and any other value is rejected. The reverse writes the mode back. Mapping version 1.4.0. Refs #6
Member
Author
|
Closing. This change landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps the payload's top-level
mode(plan|operate) toexperiment.mode. A payload without it stays in plan mode, and any other value is rejected by a strict lookup. The reverse writes the mode back. Mapping version 1.4.0.The issue also proposed a fixed
capacity.maxon every transmission arc. A real Calliope 0.7.0.dev7 run through MEME shows this is not needed. An operate job whose arcs carry onlyexpandable: truesolves, and gives the same flows and unmet demand as the plan run of the same payload, and as an operate run with bounded arcs. Calliope usesflow_cap_maxas the fixed size when it is set and leaves the arc unbounded otherwise. The mapping therefore leaves transmission unchanged.Stacked on #4.
Tests:
go test ./...andgo vet ./...pass.TestMappingOperateModeand theunknown modecase ofTestMappingRejectsUnconvertibleValuesfail against the 1.3.0 mapping and pass with this change. The reverse golden gains"mode": "plan".