Repository navigation
fix(percentile): fail the run when a month mosaic fails - #28
Merged
Merged
Conversation
construct_and_save_mosaics() in all three percentile indexers logged a failed month and carried on, and _build_month_mosaic() returned "no spatial maps" and "no readable source files" as ordinary status strings. The process exited 0 however many months failed: a MERRA-2 run whose mosaic workers all crashed wrote none of its 36 files and still reported success. Both worker failure cases now raise. Every month is still attempted, then construct_and_save_mosaics() raises RuntimeError naming the failed months, so the process exits non-zero. Closes #26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
construct_and_save_mosaics()in all three percentile indexers (COSMO-REA6, ERA5-Land, MERRA-2) logged a failed month and carried on, and_build_month_mosaic()returned "no spatial maps" and "no readable source files" as ordinary status strings. The process exited 0 however many months failed.construct_and_save_mosaics()then raisesRuntimeErrornaming the failed months, so the process exits non-zero.Closes #26.
Testing
test_failed_months_fail_the_run(all three providers) fails before the change withDID NOT RAISE RuntimeErrorand passes after.ruff check src/,mypy src: cleanpytest -q: 229 passed