Repository navigation
bench: add -push-options to send push options with every push - #21
Merged
Merged
Conversation
The repeatable flag sets Workload.PushOptions, which every push carries: measured pushes, session ref deletes and the stale-ref sweep. Options containing newline or NUL are rejected, as git does. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io> Entire-Checkpoint: 21357a0b9ba6
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit de52f5f. Configure here.
go-git drops push options a server doesn't advertise and the push still succeeds, so a requested ci.skip could silently vanish and the run would measure different remote work. NewRunner now probes the receive-pack advertisement of every repo on every node and fails before any write when push-options is missing. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io> Entire-Checkpoint: d69517bbec64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/forgemark/trails/10
The repeatable flag sets Workload.PushOptions, which every push carries: measured pushes, session ref deletes and the stale-ref sweep. Options containing newline or NUL are rejected, as git does.
Note
Low Risk
Additive, optional behavior with input validation and tests; only changes forge-side effects when operators explicitly set push options (e.g. CI skip).
Overview
Adds a repeatable
-push-optionsCLI flag (documented in the README) that mirrorsgit push -o, storing values onWorkload.PushOptions.Those options are attached to every go-git push in a run: benchmark agent pushes, session checkpoint pushes and ref deletes, and stale bench-ref cleanup. Values may include commas (one option per flag); newline/NUL are rejected in
Workload.Validate().Coverage includes a receive-pack integration test that options appear on push and delete requests.
Reviewed by Cursor Bugbot for commit de52f5f. Configure here.