Repository navigation
Housekeeping for the HTTP client and the serve history view - #22
Merged
Merged
Conversation
The probe used the generic client, which follows redirects and Go forwards Authorization to same-host and subdomain targets. It now hands redirects back, like Entire discovery, so a redirect fails the run instead of carrying the credential. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io> Entire-Checkpoint: 59f1733d7cbd
History reads whole result docs, and a long multi-target run makes them large. Remote viewers can reach history on an exposed bind. The listing now decodes only the summary fields, not every per-second series point, and at most two history reads run at once. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io>
Every request on the generic path carries Basic auth up front, and Go copies it to a redirect target on any port of the same hostname or on a subdomain. The previous commit kept the push-options probe on the configured origin. Pushes, clones and the stale-ref sweep share the same client, so the policy now lives there. A redirect within the origin is followed, as git does for the initial info/refs request. One that changes scheme, hostname or port is refused. This also lets -push-options work against forges that redirect within their own origin, such as GitLab's repo to repo.git. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io> Entire-Checkpoint: c0928221bbee
Member
Author
|
@cursor review |
The history summary decoded levels as raw JSON, so a doc with malformed levels was listed and then failed to open. Levels are small, so the summary now decodes them as bench.LevelResult like Load does. Skipping Series still keeps a listing to about one read of the file. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Paulo Gomes <paulo@entire.io>
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9531340. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/forgemark/trails/11
Redirects
probe) now share one redirect policy instead of per-call handling. Like
git's default for the initial info/refs request, a redirect within the
configured origin (same scheme, host and port) is followed. One that
leaves it stops the run with a clear error.
origin, such as GitLab's repo to repo.git.
History
target names and levels) and skips the per-second series, so listing
stays about one read per file as runs get longer. Legacy docs are
summarized exactly as before.
before, so everything listed can be opened. A doc damaged only in its
series still lists, and opening it reports the error.
predictable.
Note
Medium Risk
Changes credential-bearing HTTP redirect handling and history API behavior; mistakes could leak auth or change which runs appear in history, but behavior is covered by new tests.
Overview
Unifies forge HTTP behavior around a same-origin redirect policy on the shared client: redirects that keep scheme, hostname, and port are followed (matching git for cases like GitLab
repo→repo.git); anything that would leave the configured origin is refused so Basic auth is not forwarded to another host, port, or subdomain. The push-options probe drops its ad-hoc “no redirect” check and uses that client, so-push-optionsworks on same-origin redirects while startup and ref cleanup still fail closed on cross-origin redirects.History listing and server reads are tightened for large result files:
Listdecodes only summary fields viareadSummary(skipping per-secondSeries), with the same legacy normalization and exclusion of docs whoselevelswould failLoad. History routes are wrapped with a two-slot concurrency limit so exposed binds cannot spike memory on parallel full-doc reads.Reviewed by Cursor Bugbot for commit 9531340. Configure here.