Conversation
All consumers of the ror-nisaba-exchange-varelager-* buckets have migrated to the REST API for downloading NeTEx datasets. Remove the copy-dataset-to-private-bucket route, the whitelist/bucket configuration and the now-unused blob store copy plumbing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
All consumers of the
ror-nisaba-exchange-varelager-*buckets have migrated to the REST API for downloading NeTEx datasets, so the private-bucket copy feature is dead code. This PR removes:copy-dataset-to-private-bucketCamel route and the whitelist filter inNetexImportNotificationQueueRouteBuilder, including thenisaba.netex.publication.internal.{bucket,whitelist}injectionblobstore-copy-to-another-bucketroute (NisabaExchangeBlobStoreRoute) andAbstractBlobStoreService.copyBlobToAnotherBucket— the removed route was their only consumerTARGET_FILE_HANDLE/TARGET_CONTAINERconstants, used only by this featurenisaba.netex.publication.internal.*properties from the Helm configmap and thenetex.publication.internal.bucketvalues for dev/tst/prdThe change is behaviour-neutral for the Kafka event path: the copy step sat between event creation and the Kafka send but only mutated headers that are filtered out of the Kafka message.
Out of scope
The GCS buckets
ror-nisaba-exchange-varelager-{dev,test,production}and their IAM bindings are no longer managed by this repo (their Terraform was removed earlier) and must be deleted where infrastructure is managed now.Testing
mvn clean verifypasses: 11 tests, 0 failureshelm templaterenders cleanly with the dev values