Skip to content

Remove copy of NeTEx datasets to the varelager private bucket - #594

Open
vpaturet wants to merge 1 commit into
masterfrom
remove-varelager-bucket
Open

vpaturet wants to merge 1 commit into
masterfrom
remove-varelager-bucket

Conversation

@vpaturet

@vpaturet vpaturet commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

All consumers of the ror-nisaba-exchange-varelager-* buckets have migrated to the REST API for downloading NeTEx datasets, so the private-bucket copy feature is dead code. This PR removes:

  • The copy-dataset-to-private-bucket Camel route and the whitelist filter in NetexImportNotificationQueueRouteBuilder, including the nisaba.netex.publication.internal.{bucket,whitelist} injection
  • The blobstore-copy-to-another-bucket route (NisabaExchangeBlobStoreRoute) and AbstractBlobStoreService.copyBlobToAnotherBucket — the removed route was their only consumer
  • The TARGET_FILE_HANDLE / TARGET_CONTAINER constants, used only by this feature
  • The nisaba.netex.publication.internal.* properties from the Helm configmap and the netex.publication.internal.bucket values for dev/tst/prd
  • The feature's documentation in CLAUDE.md

The change is behaviour-neutral for the Kafka event path: the copy step sat between event creation and the Kafka send but only mutated headers that are filtered out of the Kafka message.

Out of scope

The GCS buckets ror-nisaba-exchange-varelager-{dev,test,production} and their IAM bindings are no longer managed by this repo (their Terraform was removed earlier) and must be deleted where infrastructure is managed now.

Testing

  • mvn clean verify passes: 11 tests, 0 failures
  • helm template renders cleanly with the dev values
  • Grep confirms no remaining references to varelager, the whitelist, or the copy plumbing

All consumers of the ror-nisaba-exchange-varelager-* buckets have
migrated to the REST API for downloading NeTEx datasets. Remove the
copy-dataset-to-private-bucket route, the whitelist/bucket
configuration and the now-unused blob store copy plumbing.
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant