Repository navigation
Conversation
Relax the fitsbolt pin to >=0.3.1,<0.4 and require cutana>=0.4.0. fitsbolt 0.3.1 fixes the fits_extension=None validation crash that motivated the ==0.2.0 pin, and cutana 0.4.0 requires it, so the old pin silently forced cutana back to 0.3.1. - Upgrade fitsbolt<0.3 configs stored in checkpoints on load, so models saved with fitsbolt 0.2 keep working for prediction - Adapt the interpolation-order test to fitsbolt's OpenCV resize (orders 0-4; order 4 = INTER_AREA) - Match cutana cutouts by source ID in the normalisation consistency test, as cutana's streaming orchestrator yields batches unordered Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=0.3.1,<0.4and requirecutana>=0.4.0. fitsbolt 0.3.1 fixes thefits_extension=Nonevalidation crash that motivated the==0.2.0pin (f72b3db). cutana 0.4.0 requiresfitsbolt>=0.3.1, so the old pin silently forced pip to fall back to cutana 0.3.1 (noticed in the Euclid EC GPU datalab image).fitsbolt_cfgthat has no*_n_sampleskeys and keeps the midtones parameters as scalars. Under fitsbolt 0.3, prediction with such a model raisedTypeError: '>' not supported between instances of 'int' and 'DotMap'for every normalisation method except ZSCALE.load_checkpointnow upgrades these configs in place (None= use all pixels, which matches the pre-0.3 behaviour).interpolation_orderis now 0–4 (4 =INTER_AREA, which is identical to nearest neighbour when upscaling). The default (1, linear) is unchanged.test_cutana_vs_training_normalisationpaired images by position and failed under parallel load (max abs diff = 254), so it now pairs them by source ID. The production path inprediction_process_cutana.pyalready maps results bymetadata["source_id"]and is unaffected.Validation
process_single_wrapperfor all 6 normalisation methods. Before this change: 5/6 fail. After: 6/6 pass. This case is now covered by a unit test.load_and_process_wrappervsload_and_process_single_wrapper):Test plan
-n 8and 1× seriallyruff check/ruff format --checkclean on all touched files🤖 Generated with Claude Code