web: make the trace drawer instruction-object pane resizable#255
Open
gnidan wants to merge 1 commit into
Open
Conversation
Replace the instruction-object footer's fixed max-height with a user-adjustable height. A drag handle straddles the divider above the footer (styled to match the drawer's own resize handle); dragging up grows the object pane and shrinks the instructions/state row, dragging down reverses. The row keeps flex-filling whatever height is left. The height is clamped to a minimum so the pane stays usable while open and a maximum that reserves room for the controls and the instructions/state row, so it can't swallow the drawer. Toggling the pane off still hides it entirely. Drag state is per-session.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the trace drawer layout work. The
ethdebug/format/instructionfooter pane in the trace playground drawer had a fixed height cap; this makes it user-resizable.max-heightand is clamped: a minimum so the pane stays usable while open, and a maximum that reserves space for the controls and the instructions/state row so the footer can't swallow the drawer. Toggling the pane off still hides it entirely.Display-only. Best viewed on the deploy preview: open the trace playground, enable the instruction-object pane, and drag its top edge.