Repository navigation
feat: Add test harness - #11
Merged
Merged
Conversation
eureka-cpu
force-pushed
the
eureka-cpu/add-test-harness
branch
from
February 1, 2026 02:16
a0a317d to
5bac466
Compare
andrewvious
reviewed
Feb 1, 2026
| (targets test_ns) ; the Dune target name | ||
| (deps test_ns.rs) ; path relative to this dune file | ||
| (action | ||
| (run rustc --test %{deps} -o %{targets} --allow warnings))) |
Collaborator
There was a problem hiding this comment.
pretty cool that you can do this
andrewvious
reviewed
Feb 1, 2026
| .expect("failed to canonicalize path to ns binary") | ||
| } | ||
|
|
||
| fn assert_stdout_eq(stdout: &[u8], expected: &[&str]) { |
Collaborator
There was a problem hiding this comment.
Could this still be accomplished with built-in asserts? Regardless pretty cool, and if so then its a very nice touch!
Owner
Author
There was a problem hiding this comment.
It's just for utility, but yes. If you use the regular assert it will print out extra stuff that we don't need.
andrewvious
approved these changes
Feb 1, 2026
andrewvious
left a comment
andrewvious
left a comment
Collaborator
There was a problem hiding this comment.
🚀 LGTM, going to test out after merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
printcmdflag for printing the command instead of running it.Uses
duneas the build tool to invokerustcto build a test suite.Adds additional checks to the default derivation, and adds default derivation to flake checks.
Bumps version patch.