Repository navigation
fix(streaming): preserve routed byte output and enforce builtin budgets - #2749
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | c090e75 | Commit Preview URL Branch Preview URL |
Oct 18 2026, 11:42 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Streaming builtin readers now charge the shared input budget and admit record/collector storage before growth. Live execution delivers saved stdout/stderr descriptors through the awaited output pumps, preserves raw bytes in input process substitutions, and keeps streaming utilities live through descriptor/file redirects. Background output completing at shell exit drains before execution closes, including scripts without an explicit
wait.Why
Bounded pipes did not bound growing records or account for streamed input. Saved descriptor output could disappear from live execution,
<(...)decoded binary data through a shell-text boundary, and adding2>&1could make a final filter wait for producer completion.Before / After
exec 3>&1 >out; echo hi >&3: live stdout was empty; now sinks and capture receivehi\n, subject to output caps and sink errors.cat <(printf '\377\000A'): output wasef bf bd 41; now it isff 00 41, matching Bash.cat 2>&1andgrep first 2>&1now deliver their first output before the producer can finish.Existing buffered process-substitution, utility, background-job and tool-queue limitations remain documented.
Risk
Validation
just pre-prandjust testpassed using the container's provided Linux subreaper: 3,885 core unit tests, 2,591 integration tests (four existing ignores), and 19 failpoint tests, plus workspace/doc/script checks.cargo clippy --all-targets --all-features -- -D warningspassed.Checklist