Skip to content

feat(bashkit): add feature-gated warm_up() entry point - #2750

Merged
chaliy merged 1 commit into
mainfrom
add-bashkit-warmup-gated
Oct 19, 2026
Merged

chaliy merged 1 commit into
mainfrom
add-bashkit-warmup-gated

Conversation

@chaliy

@chaliy chaliy commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

What changed

New crate-level bashkit::warm_up() that warms every enabled runtime. With the cpython feature it loads the embedded CPython interpreter (delegates to CPython::warm_up()); without it, a no-op returning Ok. All in-repo callers (examples, bench) and docs now use the new entry point instead of reaching into CPython directly.

Why

Startup code should not name a specific runtime. Callers get one stable entry point; new runtimes needing eager load hook into the same function later.

Before / After

No observable behavior change: same interpreter load, same timing, moved behind a feature gate. Evidence:

  • cargo test -p bashkit --lib --features cpython cpython — 15/15 pass, incl. new crate_warm_up_delegates_to_cpython
  • just test green, just pre-pr green
  • Smoke: cpython_load example (1 tenant, 1 call) through the new entry point — 0 failures

Risk

  • Low. Pure delegation; CPython::warm_up() kept as the underlying primitive.

Checklist

  • Tests added or updated
  • Backward compatibility considered (CPython::warm_up() retained)

Produced by yolop

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 42ba687 Commit Preview URL

Branch Preview URL
Oct 19 2026, 03:19 AM

@chaliy
chaliy merged commit dc310a2 into main Oct 19, 2026
53 checks passed
@chaliy
chaliy deleted the add-bashkit-warmup-gated branch October 19, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant