Repository navigation
feat(bashkit): add feature-gated warm_up() entry point - #2750
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 42ba687 | Commit Preview URL Branch Preview URL |
Oct 19 2026, 03:19 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
New crate-level
bashkit::warm_up()that warms every enabled runtime. With thecpythonfeature it loads the embedded CPython interpreter (delegates toCPython::warm_up()); without it, a no-op returningOk. All in-repo callers (examples, bench) and docs now use the new entry point instead of reaching intoCPythondirectly.Why
Startup code should not name a specific runtime. Callers get one stable entry point; new runtimes needing eager load hook into the same function later.
Before / After
No observable behavior change: same interpreter load, same timing, moved behind a feature gate. Evidence:
cargo test -p bashkit --lib --features cpython cpython— 15/15 pass, incl. newcrate_warm_up_delegates_to_cpythonjust testgreen,just pre-prgreencpython_loadexample (1 tenant, 1 call) through the new entry point — 0 failuresRisk
CPython::warm_up()kept as the underlying primitive.Checklist
CPython::warm_up()retained)Produced by yolop