Repository navigation
feat(documents): markkit as default Office converter, deprecate office - #183
Merged
Merged
Conversation
Add MarkkitConverter (docs-markkit, default) converting DOCX, XLSX/XLSM, XLS and ODS through the markkit crate on the shared blocking path, with limits tunable via MarkkitConverter::with_markkit. Register `markkit` in DocumentConversionSettings. Deprecate OfficeConverter: docs-office is no longer default nor part of docs-all; when enabled it runs after markkit and remains the only PPTX/XLSB backend. Gate the PDF integration test on docs-pdf. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2vd61x8kbPtmDxze9Q4Gi
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2vd61x8kbPtmDxze9Q4Gi
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
markkit (0.1.0, crates.io) becomes the default Office backend. The in-crate
officeconverter from #181 is deprecated and off by default.docs-markkitfeature, on by default. It addsMarkkitConverter(namemarkkit, local) for DOCX, XLSX/XLSM, XLS and ODS.markkit_docx,markkit_xlsx,markkit_xlsandmarkkit_ods.MarkkitConverter::with_markkit(Markkit::builder()…).MarkkitandMarkkitBuilderare re-exported fromfetchkit::documents.docs-pdf+docs-officebecomesdocs-pdf+docs-markkit.docs-allnow includes markkit and excludes office.OfficeConverteris#[deprecated]. It still works behinddocs-office, and when that feature is enabled it runs after markkit as a fallback.--converter markkit/converters=["markkit"]are accepted. When a feature is missing, the error says so.Why
The repo owner decided that #181's in-crate Office parsing is not the implementation to keep. Office parsing moves to markkit, which fetchkit's design already planned as a pluggable backend. markkit has zip-bomb, archive and spreadsheet-grid limits, and it skips hidden sheets by default.
Before / After
Before (default build):
fetchkit fetch …/demo.docxgaveextraction_method: "office_docx".After:
Local files:
.xlsxgivesmarkkit_xlsx(with ahidden_sheet_skippedwarning),.xlsgivesmarkkit_xls,.odsgivesmarkkit_ods, and a large sheet carries atruncated_sheetwarning. Legacy.docis still rejected with "DOC conversion is not enabled".Risk
docs-officerestores them.officeused 1,000 × 50. Output is still capped bymax_body_size.cfb,uuid,regex,anyhow,mime,unicode-segmentation.Checklist
cargo test --workspace, plus feature sets with no defaults,docs-markkitonly, anddocs-all,docs-office. clippy-D warningspasses across the same sets.check_okf.pypasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y2vd61x8kbPtmDxze9Q4Gi
Generated by Claude Code