Skip to content

[eas-cli] add apple platform value to observe commands - #4276

Open
kadikraman wants to merge 8 commits into
kadikraman/add-environment-filterfrom
kadikraman/add-apple-platform
Open

[eas-cli] add apple platform value to observe commands#4276
kadikraman wants to merge 8 commits into
kadikraman/add-environment-filterfrom
kadikraman/add-apple-platform

Conversation

@kadikraman

@kadikraman kadikraman commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Why

Part of ENG-26159.

The dashboard's Apple platform filter covers iOS, iPadOS, tvOS, and macOS together, but the CLI's --platform flag could only express a single platform. We want to match the filters on the dashboard so we could correctly pre-fill them in the prompts.

This also fixes a bug: --platform ipados, tvos, and macos were accepted but silently queried iOS data.

How

Update all commands so that --platform apple will query all apple platforms. Other behaviour is unchanged.

Test Plan

Unit tests and querying locally on staging.

Metrics summary

eas observe:metrics-summary --platform apple
eas observe:metrics-summary --platform macos

apple renders one combined "Apple" section; macos now correctly reports no data for an iOS-only app (it previously returned the iOS data).

Metrics

eas observe:metrics tti --platform apple --limit 3

Routes

eas observe:routes --platform apple

Events

eas observe:events --platform apple            # summary of event names + counts

Versions

eas observe:versions --platform apple

@linear-code

linear-code Bot commented Aug 25, 2026

Copy link
Copy Markdown

ENG-26159

@kadikraman
kadikraman marked this pull request as ready for review August 25, 2026 13:25
@kadikraman
kadikraman requested a review from douglowder August 25, 2026 13:25
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.06%. Comparing base (b580e89) to head (8743289).

Files with missing lines Patch % Lines
packages/eas-cli/src/observe/fetchVersions.ts 25.00% 3 Missing ⚠️
...ckages/eas-cli/src/graphql/queries/ObserveQuery.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/observe/formatVersions.ts 50.00% 1 Missing ⚠️
packages/eas-cli/src/observe/platforms.ts 95.46% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           kadikraman/add-environment-filter    #4276      +/-   ##
=====================================================================
+ Coverage                              64.05%   64.06%   +0.01%     
=====================================================================
  Files                                   1042     1042              
  Lines                                  48015    48019       +4     
  Branches                               10135    10136       +1     
=====================================================================
+ Hits                                   30751    30757       +6     
+ Misses                                 17148    17146       -2     
  Partials                                 116      116              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants