[eas-cli] add apple platform value to observe commands - #4276
Open
kadikraman wants to merge 8 commits into
Open
Conversation
kadikraman
marked this pull request as ready for review
August 25, 2026 13:25
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## kadikraman/add-environment-filter #4276 +/- ##
=====================================================================
+ Coverage 64.05% 64.06% +0.01%
=====================================================================
Files 1042 1042
Lines 48015 48019 +4
Branches 10135 10136 +1
=====================================================================
+ Hits 30751 30757 +6
+ Misses 17148 17146 -2
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
douglowder
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of ENG-26159.
The dashboard's Apple platform filter covers iOS, iPadOS, tvOS, and macOS together, but the CLI's
--platformflag could only express a single platform. We want to match the filters on the dashboard so we could correctly pre-fill them in the prompts.This also fixes a bug:
--platform ipados,tvos, andmacoswere accepted but silently queried iOS data.How
Update all commands so that
--platform applewill query all apple platforms. Other behaviour is unchanged.Test Plan
Unit tests and querying locally on staging.
Metrics summary
applerenders one combined "Apple" section;macosnow correctly reports no data for an iOS-only app (it previously returned the iOS data).Metrics
Routes
Events
eas observe:events --platform apple # summary of event names + countsVersions