Skip to content

[eas-cli] Add prebuild fallback regression tests - #4285

Open
brentvatne wants to merge 2 commits into
brent/local-build-expo-bunyanfrom
brent/prebuild-fallback-regression-test
Open

[eas-cli] Add prebuild fallback regression tests#4285
brentvatne wants to merge 2 commits into
brent/local-build-expo-bunyanfrom
brent/prebuild-fallback-regression-test

Conversation

@brentvatne

@brentvatne brentvatne commented Aug 26, 2026

Copy link
Copy Markdown
Member

Why

EAS CLI has a bundled @expo/prebuild-config fallback for iOS entitlement introspection when Expo is unavailable or the project-local Expo CLI fails. A dependency bump can silently make that fallback require Expo and substantially expand published installs.

How

Add regression coverage that verifies:

  • the bundled fallback works when Expo is not installed;
  • the fallback works after the local Expo CLI fails;
  • build-profile environment variables are visible during introspection and restored afterward;
  • the bundled prebuild package does not declare Expo as a required peer dependency.

Test Plan

  • yarn workspace eas-cli test src/project/ios/__tests__/entitlements-test.ts --runInBand --watchman=false (3 tests)
  • yarn workspace eas-cli typecheck

Stack

  1. #4281 — minizlib 3.1.0
  2. #4282 — uuid v11
  3. #4283 — remove lodash.get
  4. #4284 — local-build @expo/bunyan
  5. #4285 — prebuild fallback regression tests

This final stack item is regression coverage only; it does not change a dependency.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (brent/local-build-expo-bunyan@acabc8f). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             brent/local-build-expo-bunyan    #4285   +/-   ##
================================================================
  Coverage                                 ?   64.39%           
================================================================
  Files                                    ?     1050           
  Lines                                    ?    48379           
  Branches                                 ?    10207           
================================================================
  Hits                                     ?    31150           
  Misses                                   ?    17113           
  Partials                                 ?      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brentvatne
brentvatne force-pushed the brent/prebuild-fallback-regression-test branch from c004756 to fb2fc4a Compare August 26, 2026 21:05
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@brentvatne
brentvatne requested a review from douglowder August 27, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants