[eas-cli] Add dynamic retries for deploy command - #4299
Merged
Conversation
- We should delay depending on number of total requests - We should delay longer and retry more often for network failures - We should issue a warning when we're retrying but already waited for 30s Main motivation here is that: - We should not make it feel like the deployment is stuck or delay it unnecessarily - We should avoid situations where it's faster to retry a full deployment
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
kitten
force-pushed
the
@kitten/fix/hosting-generous-upload-retries
branch
from
August 27, 2026 22:16
877e765 to
210f0c7
Compare
kitten
force-pushed
the
@kitten/fix/hosting-generous-upload-retries
branch
from
August 27, 2026 22:26
210f0c7 to
4045f1a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4299 +/- ##
==========================================
+ Coverage 64.41% 64.70% +0.29%
==========================================
Files 1048 1048
Lines 48425 48474 +49
Branches 10203 10218 +15
==========================================
+ Hits 31188 31359 +171
+ Misses 17121 16999 -122
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kadikraman
approved these changes
Aug 28, 2026
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When we encounter transient errors, we don't account for network errors that could be an ongoing internal failure or outage on the machine that's deploying. This is especially punishing when the deployment is larger and has more missing assets to upload, since it has to fully retry.
How
Test Plan