Skip to content

[eas-cli] Tolerate unknown account roles - #4300

Draft
byronkarlen wants to merge 1 commit into
mainfrom
tolerate-unknown-account-roles
Draft

[eas-cli] Tolerate unknown account roles#4300
byronkarlen wants to merge 1 commit into
mainfrom
tolerate-unknown-account-roles

Conversation

@byronkarlen

@byronkarlen byronkarlen commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Why

Make the eas-cli forwards compatible for when any additional roles get added server-side. If/when we add additional roles, we should add them here explicitly.

How

In getLabelForRole, derive label from server-side value itself if the role is new/unknown.

Test Plan

Uncommented ADMIN branch on switch statement. Then built it and ran yarn run eas account:view and it still showed Admin in catch-all case.

@byronkarlen byronkarlen added the no changelog PR that doesn't require a changelog entry label Aug 27, 2026
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@byronkarlen
byronkarlen requested a review from tchayen August 27, 2026 23:39
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.40%. Comparing base (66dbcaf) to head (7aedfee).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/account/view.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4300      +/-   ##
==========================================
+ Coverage   64.05%   64.40%   +0.36%     
==========================================
  Files        1042     1048       +6     
  Lines       48009    48429     +420     
  Branches    10130    10204      +74     
==========================================
+ Hits        30745    31188     +443     
+ Misses      17148    17125      -23     
  Partials      116      116              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@byronkarlen
byronkarlen marked this pull request as draft August 27, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant