[eas-cli] Tolerate unknown account roles - #4300
Draft
byronkarlen wants to merge 1 commit into
Draft
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4300 +/- ##
==========================================
+ Coverage 64.05% 64.40% +0.36%
==========================================
Files 1042 1048 +6
Lines 48009 48429 +420
Branches 10130 10204 +74
==========================================
+ Hits 30745 31188 +443
+ Misses 17148 17125 -23
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
byronkarlen
marked this pull request as draft
August 27, 2026 23:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Make the eas-cli forwards compatible for when any additional roles get added server-side. If/when we add additional roles, we should add them here explicitly.
How
In
getLabelForRole, derive label from server-side value itself if the role is new/unknown.Test Plan
Uncommented ADMIN branch on switch statement. Then built it and ran
yarn run eas account:viewand it still showed Admin in catch-all case.