[eas-cli] gate device-run-session serve-sim with the session token - #4306
Open
gwdp wants to merge 1 commit into
Open
[eas-cli] gate device-run-session serve-sim with the session token#4306gwdp wants to merge 1 commit into
gwdp wants to merge 1 commit into
Conversation
gwdp
force-pushed
the
gwdp/serve-sim-require-token
branch
2 times, most recently
from
August 28, 2026 21:35
29e0327 to
3a32d5c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4306 +/- ##
==========================================
+ Coverage 64.82% 64.89% +0.08%
==========================================
Files 1048 1048
Lines 48556 48571 +15
Branches 10240 10248 +8
==========================================
+ Hits 31470 31516 +46
+ Misses 16970 16939 -31
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
marked this pull request as ready for review
August 28, 2026 22:14
gwdp
force-pushed
the
gwdp/serve-sim-require-token
branch
2 times, most recently
from
August 29, 2026 02:31
9a7dfce to
74fa11b
Compare
gwdp
force-pushed
the
gwdp/serve-sim-require-token
branch
from
August 29, 2026 02:32
74fa11b to
d48b193
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
serve-sim can now require a session token before it serves anything (assuming expo/serve-sim#49 merge). This turns that on for device run sessions.
How
Pass
--require-tokenwhen we start serve-sim, then carry the token:previewTokenorwebPreviewToken; Usage on expo/universe#30571/metricsstream we collect, which is gated nowNeeds a serve-sim release with the flag first. An older serve-sim rejects the unknown option and will not start, so this should land after that publishes.
Test Plan