[menu-bar] Add Simulator camera MVP - #369
Open
expo-tuft[bot] wants to merge 3 commits into
Open
expo-tuft[bot] wants to merge 3 commits into
expo-tuft[bot] wants to merge 3 commits into
Conversation
Co-authored-by: gabrieldonadel <11707729+gabrieldonadel@users.noreply.github.com>
Co-authored-by: gabrieldonadel <11707729+gabrieldonadel@users.noreply.github.com>
Comment on lines
+18
to
+24
| {Platform.OS === 'macos' && ( | ||
| <Item | ||
| onPress={() => WindowsNavigator.open('SimulatorCamera')} | ||
| testID="simulator-camera-button"> | ||
| <Text>Simulator Camera…</Text> | ||
| </Item> | ||
| )} |
Member
There was a problem hiding this comment.
This should live inside the Settings screen
Author
There was a problem hiding this comment.
Moved the Simulator Camera controls into the macOS Settings screen and removed the separate popover item/window in 17804e3.
Co-authored-by: gabrieldonadel <11707729+gabrieldonadel@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
yarn workspace orbit typecheckyarn test:simulator-cameraCurrent scope
Photo capture, movie recording, metadata output, and UIImagePickerController interception are intentionally left for follow-up.