Skip to content

fix exact-size iterator contracts for rows and columns - #413

Open
ginavalent wants to merge 1 commit into
facebook:mainfrom
ginavalent:main
Open

fix exact-size iterator contracts for rows and columns#413
ginavalent wants to merge 1 commit into
facebook:mainfrom
ginavalent:main

Conversation

@ginavalent

Copy link
Copy Markdown

Fix ExactSizeIterator implementations for:

  • RowIterator
  • ColumnIter
  • ColumnIterMut

These iterators previously returned the total number of rows or columns from len(), even after elements had been consumed. They also inherited the default non-exact Iterator::size_hint() implementation.

Each iterator now reports the number of remaining elements through an exact size_hint():

(remaining, Some(remaining))

The ExactSizeIterator implementations now use the default len() implementation derived from size_hint().

Signed-off-by: ginavalent <ginavalent@outlook.com>
@meta-cla

meta-cla Bot commented Sep 13, 2026

Copy link
Copy Markdown

Hi @ginavalent!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@ginavalent

Copy link
Copy Markdown
Author

signed.

@meta-cla

meta-cla Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the cla signed label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant