Repository navigation
Map and book: a one-row local graph toolbar, links between the cards, splitter grips - #803
Conversation
- A drag ends on any release the splitter hears, as before the grip change; the window only hears the dragging pointer away from the splitter, where the browser gave no pointer capture. A browser taking the pointer back sent pointerId 0 and left the drag running. - The map's and Contents' tabs over a shut map's edge stand above the reader's splitter, as they did for touch: at 20px it covered their middle. - The splitter's line is shown again only while hovered or dragged; the grip marks it, and keeps a system colour in forced colours. - The routing test zooms out to the whole level-3 graph and counts all 17 links; at the opening zoom the chain's far end is off the stage.
At 20px and above the tabs, the reader's splitter could not be dragged at its middle, where the map's tab sits, so a drag there opened nothing. Over a shut map it now narrows to its old 8px, without the grip, and the tabs stand under it again, as before the grip change; a finger's 24px splitter still sits under them.
In the book, Material drew the panel's <details> as a note box, with an icon and a border, which made the panel taller than the one it replaced. Details is now a button in the toolbar row that shows the title and the hub chips below it. Links that don't touch the focus were drawn at 14%, too faint to follow; they are at 40%. The CHANGELOG says what changed.
- Details kept its state in a variable that showLocalPanel declared again for the chips' "+N more" button. With more than 12 hubs, a press on Details marked "+1 more" expanded and left Details collapsed, and the next redraw closed it. The toggle has its own name and class now, and the hubs test checks its state before and after a chip opens another graph. - A splitter 20px wide took presses 10px into Contents and into the statement list, over their scrollbars. It now takes presses only 4px into the pane on its left, as the 8px splitter did, and the grab test checks that a press 7px in reaches the pane. - A dotted via link between two results off the focus is drawn as faint as a plain one. - The keyboard chip test opens Details before it reaches a chip.
|
Review at ab9dfa7: no blockers. The before and after screenshots, against Jack's three complaints:
The bundle diff is only the blueprint-dag change. Of the bundle's three inputs, only Nits:
Posted by Claude Code, at Jack's request. |
- A link between two cards side by side stepped a lane halfway: the sweep that keeps ports across a corridor apart also moved a route's own end away from its start. A route's two ends may now share a line, on the whole-project map too, and the link runs straight. - A link skipping a column with one or two cards went round it at the top or bottom of the whole graph. Local graphs now also pass a column just past its own first and last cards, where it leaves room. - The splitter draws its focus ring inside the part that takes presses; the clip cut off its left side.
|
Blockers-only check at d05bda2: no blockers.
The whole-project map is not byte-identical, though:
That is the same fix, applied to the whole map. If it's meant, the CHANGELOG could say so. No bundle rebuild is needed: none of the bundle's three inputs changed, and no built asset embeds Posted by Claude Code, at Jack's request. |
Premise
What changes
Toolbar.
showLocalPanelbuilds one row:← Map, labelled "Back to the map";N / M, with the full sentence as its title (a result that builds on nothing says so in words);aria-expanded) that shows the title and the hub chips below the row.It is a button rather than
<details>because Material draws a<details>in the book as a note box. Details stays open when the focus or the level changes.Links.
AutoformMapLayout.routeColumns(routes, boxes)routes a local graph's links through the gaps between its columns and cards. It transposes the boxes and reusesrouteThroughGaps, which already routes the whole-project map's links between rows.localLinkdraws the routed path and puts a "via n" label at the route's midpoint by length. Links that don't touch the focus are drawn at 40%, and 80% on hover.localEnds), not round the top or bottom of the whole graph.Splitters.
Bundle.
blueprint-explorer.min.jsis rebuilt fromblueprint-dag.js.CHANGELOG. Two Changed entries and one Fixed entry.
Left as is
main.main.Checks
test_local_graph_controls_are_compact_and_details_are_optional: one row under 72px; Details shows the title; Back closes the graph.test_rendered_local_connections_do_not_cross_unrelated_result_cards: a 16-result chain at level 3, zoomed out, draws all 17 links, and none runs through a card it doesn't join.test_pane_dividers_can_be_grabbed_on_both_sides_of_the_visible_border(4 cases) andtest_pane_drag_continues_if_the_browser_refuses_pointer_capture(2 cases).main) and after, of a 24-result fixture, in thescreenshotsartifact of each run:map-sylow-level3.png: the links at level 3, where off-focus links used to loop round the top and bottom of the graph (the review's question).map-sylow-level1.png: the panel and the links at level 1.book-sylow-local.png: the same graph in the book, with the splitters' grips.book-splitter-hover.png: a hovered grip.map-sylow-details.pngin https://github.com/facebookresearch/autoform-bot/actions/runs/43403115071.Posted by Claude Code, at Jack's request.