Repository navigation
fix(logs): deliver raw gzip payload to Firehose subscription destinations - #2720
Merged
Merged
Conversation
…ions CloudWatch Logs subscription filters targeting Firehose passed the base64 text of the gzip payload as the record, so delivered S3 objects held base64 instead of gzip. In AWS the Firehose record is the gzip payload itself; base64 is only the SQS/Lambda/Kinesis wire encoding.
vieiralucas
force-pushed
the
fix/logs-firehose-raw-gzip
branch
from
October 16, 2026 10:20
32d51a5 to
38e705e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudWatch Logs subscription filters with a Firehose destination passed
encoded.as_bytes()(the base64 text of the gzip payload) as the Firehose record, so the delivered S3 object contained base64 text rather than gzip. In AWS the Firehose record is the gzip-compressed CloudWatch Logs payload itself, and the object is readable withzcat. Base64 is only the wire encoding for SQS/Lambda (and the Kinesis path already decodes it back to bytes).Found while reviewing #2715. Adds a unit test asserting the record starts with the gzip magic and decodes to the DATA_MESSAGE payload.
Summary by cubic
Fixes CloudWatch Logs subscription filters delivering base64 text instead of the gzip payload to Firehose destinations, so delivered S3 objects now contain gzip data readable with
zcatas in AWS.DATA_MESSAGEpayload.Written for commit 38e705e. Summary will update on new commits.