Repository navigation
chore(conformance): fail on any failing variant; re-baseline at 257,288/257,288 - #2736
Merged
Merged
Conversation
- check reports every operation with a failing variant as a failure; the per-service ratchet keeps catching a service that loses variants, now with no default flake margin (FAKECLOUD_CONFORMANCE_FLAKE_MARGIN still relaxes local runs). - The sweep server gets 60s to start (a cold debug binary missed 5s).
Every implemented service passes every variant on the refreshed models (7,610 probed operations; RDS runtime-dependent variants re-probed against a Docker-backed server). Variant counts synced across README, AGENTS.md, docs, landing pages and llms.txt; check-doc-counts passes.
- Drop the overall ratchet: it could never fire before a per-service one. - An operation with no variants counts as unchecked, so it fails the check. - Status lines and the check/step descriptions name the new failure rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every implemented service now passes every variant on the refreshed AWS models, so the check enforces that.
conformance checkfails on any failing variant and lists each failing operation (service Op: passed/total). An operation with zero variants also fails, since nothing checked it.conformance-baseline.jsonstays, with no default flake margin;FAKECLOUD_CONFORMANCE_FLAKE_MARGINcan still relax a local run, and CI doesn't set it.vs/pages,llms.txt/llms-full.txtand the home template (blog posts untouched).check-doc-counts.shpasses, and the ops index is unchanged.Test plan
cargo +stable clippy -p fakecloud-conformance --all-targets -D warnings, fmtevery_failing_operation_is_a_check_failurebash scripts/check-doc-counts.shOK;generate-operations-index.shno diffconformance-checkruns the strict check against the new baselineSummary by cubic
Conformance checks now fail on any failing or unchecked variant, making the 100% pass requirement enforceable in CI. The baseline is refreshed to 257,288 passing variants across 106 services.
FAKECLOUD_CONFORMANCE_FLAKE_MARGINcan relax local runs.Written for commit 3795ed0. Summary will update on new commits.