Skip to content

Active transfer local IP resolver - #674

Open
syncplify wants to merge 3 commits into
fclairamb:mainfrom
syncplify:active-transfer-local-ip
Open

Active transfer local IP resolver#674
syncplify wants to merge 3 commits into
fclairamb:mainfrom
syncplify:active-transfer-local-ip

Conversation

@syncplify

Copy link
Copy Markdown
Contributor

This change fills a gap in the library, specifically on multi homed hosts (hosts with multiple NICs, or NICs with multiple IP addresses) where the library didn't have the capability to initiate the outbound connection to the client, when in active FTP mode, from the same IP address as the inbound connection it's responding to.
For flexibility this adds an optional resolver in the driver, to let developers implement their own resolution logic. This will typically be "same as binding" but this design doesn't restrict the developer to only that one option.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.47%. Comparing base (e6a2418) to head (900227d).

Files with missing lines Patch % Lines
transfer_active.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   87.48%   87.47%   -0.02%     
==========================================
  Files          13       13              
  Lines        2102     2108       +6     
==========================================
+ Hits         1839     1844       +5     
  Misses        175      175              
- Partials       88       89       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant