feat(web): onboarding select 启用 hover 提亮开关 - #1256
Conversation
三个位于近黑画布上的 select 调用点设置 ui 侧的 data-hover-lighten （依赖 felinics/ui#26，合并前需先 bump gitlink）： - Step2 Language、Step3 Client Type：SelectTrigger 直接加属性 - Step4 Chat Model：ModelSelect 新增 hoverLighten prop 透传 dark 下这些 trigger 的 hover 由不可见的纯黑压暗翻转为白色 8% overlay； light 下该属性为无操作。其余调用点保持默认压黑不动——surface 感知 极性由组件库重构统一裁决。
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
change:web
|
@qqqqqf-q Please complete the following information using the template:
Editing the description triggers another check; format feedback does not block or cancel code CI. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d07d71b6f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| data-slot="select-trigger" | ||
| data-size="default" | ||
| :data-placeholder="displayLabel ? undefined : ''" | ||
| :data-hover-lighten="hoverLighten || undefined" |
There was a problem hiding this comment.
In a clean checkout of this commit, packages/ui remains pinned to ea7c0c6b6e60a9ddfebbe9ee4d2ff5ba99f19b13, while the commit description states that data-hover-lighten is introduced only by a separate UI update. Consequently, this binding merely emits an unused DOM attribute and all three onboarding selects retain the invisible dark-theme hover behavior this change is meant to fix. Include the prerequisite gitlink bump before landing this commit.
AGENTS.md reference: AGENTS.md:L109-L109
Useful? React with 👍 / 👎.
felinics/ui#26（519a597e）：新增 data-hover-lighten 调用层开关与新 token --select-trigger-hover-lighten，默认压黑 hover 不变。 为 #1256 的 onboarding 调用点提供规则来源。
1 participant
问题
dark 主题下 onboarding 的 select（近黑画布
--background≈ RGB 17）hover 零反馈：默认 hover 是纯黑压暗填充，在 RGB 17 上没有向下行程。方案
依赖 felinics/ui#26 新增的
data-hover-lighten调用层开关，本 PR 在三个 onboarding 调用点启用：SelectTrigger直接加属性ModelSelect新增hoverLightenprop 透传到底层 buttondark 下这些 trigger 的 hover 翻转为白色 8% overlay；light 下属性为无操作（token 与默认填充相同）。其余全部调用点保持默认压黑——全局 hover 极性是组件库重构的系统设计议题，本 PR 不做。
依赖与落序
在 2 完成前，本 PR 的属性是静默无操作（规则不存在，无副作用），可安全先行 review。
验证