Skip to content

feat(ui): 补齐紧凑选择弹窗与用量菜单布局 - #25

Merged
qqqqqf-q merged 2 commits into
mainfrom
codex/cloud-footer-picker
Sep 14, 2026
Merged

qqqqqf-q merged 2 commits into
mainfrom
codex/cloud-footer-picker

Conversation

@qqqqqf-q

@qqqqqf-q qqqqqf-q commented Sep 14, 2026

Copy link
Copy Markdown
Member

Author

  • Human
  • Agent

Type

  • bug
  • feat
  • test

Summary

为团队切换提供紧凑的 CommandDialog picker 变体:标题、关闭按钮和列表共享组件层的留白,复用既有菜单行交互。
新增 DropdownMenuSummary 展示标题、百分比及说明;子菜单支持与父菜单顶边对齐。默认 palette 与 first-item 行为保持不变。

Validation

  • 改动文件 ESLint、git diff --check 通过。
  • Cloud 调用方团队切换与用量计算共 32 项测试通过;这些测试不覆盖真实弹窗视觉或键盘交互。
  • 用户接受最后一轮间距调整并授权提交,未声明完整团队切换 happy path QA。
  • 已合并最新 main 并解决两个冲突,保留自定义滚动容器和虚拟列表首行定位;子菜单滚动回归 2 项通过。

Screenshots / Recordings

当前会话有用户提供的实际界面截图;未上传截图附件。AI 桌面操作未能可靠验证最终状态。

代码量自审

5 个生产文件,新增 83 行、删除 13 行,净增 70 行。无生成文件或机械迁移。改动集中在弹窗变体、摘要行和对齐选项;复用原组件的交互,不另建团队专用组件。

Human QA

  • 已通过完整真人 QA

⚠️ No human QA — this PR has not been verified by a human yet. Remove this line once a human confirms the happy path.

@qqqqqf-q
qqqqqf-q marked this pull request as ready for review September 14, 2026 11:09
@qqqqqf-q
qqqqqf-q requested a review from a team as a code owner September 14, 2026 11:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T11:12:48.849445Z c3b3db5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qqqqqf-q
qqqqqf-q merged commit 2d17079 into main Sep 14, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3b3db57c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +70 to +72
<DialogDescription v-if="description">
{{ description }}
</DialogDescription>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep palette-only copy out of picker headers

When variant="picker" is used without explicitly passing description="", the existing truthy default makes this new branch visibly render “Search for a command to run...” even for non-search pickers such as a team chooser. Make the default variant-specific or render the description only when the caller supplied one; otherwise this generic picker exposes misleading command-palette copy.

AGENTS.md reference: AGENTS.md:L55-L55

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant