Skip to content

feat(sonner): 增加独立的编号文字复制动作 - #28

Merged
qqqqqf-q merged 4 commits into
mainfrom
codex/error-correlation-toast
Sep 17, 2026
Merged

qqqqqf-q merged 4 commits into
mainfrom
codex/error-correlation-toast

Conversation

@qqqqqf-q

@qqqqqf-q qqqqqf-q commented Sep 15, 2026

Copy link
Copy Markdown
Member

错误通知现在把完整 Request ID 作为可选中的普通文字显示,复制按钮位于右侧关闭按钮下方。复制使用与聊天 action row 相同的连续双框图标、方向和按钮规格;原 Retry 等业务动作仍独立保留。

本 PR 为 Sonner 增加可选 textAction,并把聊天已有的 CopyConnectedIcon 机械移入共享 UI。点击复制不关闭通知;pending 防止重复执行,成功短暂确认,失败原位反馈。替换、移除、卸载后的迟到结果不会污染新动作。无 textAction 时保留原通知内容和业务动作。

验证与边界

  • Memoh 消费端 3 份定向测试、15 项通过,覆盖编号文本、复制成功/失败、pending、过期结果、关闭和原 action;相关 ESLint 与 diff 检查通过。
  • 共享图标与原 action row SVG 除 data-slot 外逐字相同。聊天错误组件已在真实浏览器组件页检查默认与放大字号、中文、窄屏、长 ID;这不等于完整应用或人工 QA。
  • 本轮未重新执行全量 typecheck。此前组合全量 typecheck 仍有基线问题,不能视为当前全量绿色结论。
  • 当前 head 为 03de78b;推送后 CI 以当前 head 的远端检查为准。仍为 Draft,人工验收未完成。

代码量审计

核对远端 base 72b18e0 / head 03de78b:5 文件,+152/-21,净 +131。生产 4 文件 +151/-21;生成 barrel 1 文件 +1/-0;无新增测试文件(测试位于消费端)。生产去空行和独立注释后 +130/-16,净 +114。机械复用包含从原聊天 action row 搬入的 32 行 SVG,已计入生产,不重复累加;未另造复制图形或交互状态机。

依赖

消费端 Memoh #378,控制面与人工清单 Cloud #375。先合 UI 再固定 Memoh gitlink,Memoh 合入后再更新 Cloud 指针。

⚠️ No human QA — this PR has not been verified by a human yet. Remove this line once a human confirms the happy path.

@qqqqqf-q
qqqqqf-q marked this pull request as ready for review September 17, 2026 07:23
@qqqqqf-q
qqqqqf-q requested a review from a team as a code owner September 17, 2026 07:23
@qqqqqf-q
qqqqqf-q merged commit e9d78ac into main Sep 17, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T07:24:26.069744Z 03de78b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant