Repository navigation
fix(dns): retry hostname lookup when entering a client with no IPs - #520
Open
fullstacksushil wants to merge 1 commit into
Open
fullstacksushil wants to merge 1 commit into
fullstacksushil wants to merge 1 commit into
Conversation
A hostname is only resolved on activation, hostname change or a manual ResolveDns request. If that lookup fails (e.g. the daemon starts at login before the network or mDNS is up), the client keeps an empty IP list and every connect attempt fails until lan-mouse is restarted. Re-resolve on ClientEntered when the client has no IPs and no lookup is in flight. Fixes feschber#519 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519.
A client's hostname is only resolved on activation, on hostname change, or when the user clicks the DNS button. If that first lookup fails, for example because the daemon starts at login before the network or mDNS is up, the client keeps an empty IP list and every connect attempt fails until lan-mouse is restarted.
This re-resolves the hostname on
ClientEnteredwhen the client has no IPs and no lookup is already running, so crossing the screen edge after the network comes up is enough to recover.cargo clippy --workspace --all-targets --all-featuresandcargo test --workspacepass. I hit this on Linux (Hyprland) with a Mac peer and haven't tested the patched build end to end yet.🤖 Generated with Claude Code