Repository navigation
Conversation
|
Thanks for this contribution, @Pier53! I am sorry that you had to run into that issue with the strain limits. Indeed, I remember @talledodiego and I discussed what to do with the limits, and we decided to keep it like this awaiting a tensile law 😃 Thanks for elaborating on this in the message above. Anyway, I will have a closer look after the weekend, and @talledodiego will have a look at your solution for the strain limit issue. If possible, please go ahead implementing the |
mortenengen
left a comment
There was a problem hiding this comment.
Thanks for this nice contribution, @Pier53! I think the use of np.inf is a clever solution. I only have one comment which I would appreciate if you could fix in order to trigger the pipelines. Final approval awaits the outcome of the pipelines, i.e. whether they pass or not, and the review from @talledodiego.
|
I think I made a mistake with the get_ultimate_strain method. Because my result with and without rebar are inconsistent/wrong. Please wait a bit before the review because I'm going to fix it soon. I'm also going to fix this noqa bug. |
Hello everyone,
Please be lenient, as this is my first real public pull request. I hope I haven't made a mistake! :-)
I've started to implement ElasticFragileTension.
.get_ultimate_strain()
I had a trouble with .get_ultimate_strain() with the Parallel class because compression law returned epsillon_tension_max = 100 instead of 0.00.
return :
[
-0.0035,
100
]
So the ultimate strains of the compression_tension made with Parallel class was wrong.
Maybe you've already talk about it in past ?
I've thinked of different solutions.
So I've made a try with np.inf !
With this, i got good results :
But this was introducing some trouble in BeamSectionCalculator so i introduce a "bracket" with a large strain of 1.0.
My test file : 2026_09_18_bending_strength_concrete_only.py
Marin
I add a minimum for eps to avoid to get an np.inf value in the discretize_law
-> Do i need to add a specific marin method for ElasticFragileTension ?
Tests
All test passed.
Roadmap
I reallyenjoy doing this, but I'm not used to work on project on Github, so I need your advises ! 👍