Skip to content

fix(iris): prevent kiosk dialog render loop - #402

Merged
nemvince merged 2 commits into
mainfrom
petriktv-minor-fixes
Oct 9, 2026
Merged

nemvince merged 2 commits into
mainfrom
petriktv-minor-fixes

Conversation

@Dasa122

@Dasa122 Dasa122 commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the React maximum update depth error on the admin kiosks page.

Changes

  • Stabilize kiosk form initialization for each dialog mount.
  • Mount KioskDialog only while it is open.
  • Remove the recursive form reset effect.

Verification

  • bun run typecheck
  • bunx biome check src/components/admin/kiosk-dialog.tsx src/routes/_private/admin/kiosks.tsx
  • bun run build not run; no bundler configuration changed.

Merge Danger

Door: two-way

Blast Radius: admin kiosks

The change only affects kiosk form mounting and initialization; kiosk list data and save payloads are unchanged.

@filc-preview-vm

filc-preview-vm Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🗑️ Preview removed

Environment pr-402.preview.filc.petrik.hu
Commit fcaf2aa
URL https://pr-402.preview.filc.petrik.hu
Edge check —

Posted by filc-deployer. The preview database is its own container and is
destroyed when this pull request closes.

@filc-preview-vm
filc-preview-vm Bot temporarily deployed to preview-pr-402 October 9, 2026 17:02 Destroyed
@Dasa122

Dasa122 commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@nemvince nemvince left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okkie

@nemvince

nemvince commented Oct 9, 2026

Copy link
Copy Markdown
Member

wrong button!!!11!!

@nemvince
nemvince merged commit 63b3779 into main Oct 9, 2026
5 checks passed
@nemvince
nemvince deleted the petriktv-minor-fixes branch October 9, 2026 19:27

This branch was successfully deployed

No deployments
preview-pr-402 — fcaf2aab Deployed Oct 9, 2026 by filc-preview-vm[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants