Repository navigation
fix(auth): validate tenant ID and provider ID URL path segments - #794
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces stricter validation for OIDC, SAML, and tenant IDs by checking them against a safe URL segment pattern via a new isSafeURLSegment helper function. It also adds comprehensive unit tests to verify these validation rules. The review feedback points out redundant checks in validateOIDCConfigID and validateSAMLConfigID (specifically checking for id == "oidc." and id == "saml."), as isSafeURLSegment already rejects strings ending with a dot.
Member
|
Could you please change the base branch from master to |
Contributor
Author
|
Changed the base branch to dev. Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validates that
tenantIDandproviderIDvalues are valid URL path segments before constructing Auth and Identity Platform management request paths.Testing
auth/tenant_mgt_test.goandauth/provider_config_test.gocovering invalidtenantIDandproviderIDinputs.