Skip to content

chore(ci): Enforce and guide PRs to target the dev branch - #796

Draft
lahirumaramba wants to merge 2 commits into
devfrom
lm-enforce-dev-base
Draft

lahirumaramba wants to merge 2 commits into
devfrom
lm-enforce-dev-base

Conversation

@lahirumaramba

Copy link
Copy Markdown
Member

Add a CI check to verify pull requests target the dev branch, and update PR template, CONTRIBUTING.md, and AGENTS.md to guide contributors to target dev.

Add a CI check to verify pull requests target the dev branch, and update PR template, CONTRIBUTING.md, and AGENTS.md to guide contributors to target dev.
Update branch references from master to main in PR template, CONTRIBUTING.md, AGENTS.md, and release.yml.
@lahirumaramba
lahirumaramba requested a review from a team October 21, 2026 19:54

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository documentation, including the pull request template, AGENTS.md, and CONTRIBUTING.md, to clarify that all development work and pull requests must target the dev branch instead of main (formerly master). It also updates references from master to main and updates the git clone instructions to target the dev branch. Feedback on these changes suggests using the /pull/new/dev URL format in CONTRIBUTING.md instead of /compare/dev... to maintain consistency with the previous URL structure.

Comment thread CONTRIBUTING.md

Sweet, we'd love to accept your contribution!
[Open a new pull request](https://github.com/firebase/firebase-admin-go/pull/new/master) and fill
[Open a new pull request](https://github.com/firebase/firebase-admin-go/compare/dev...) and fill

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the /pull/new/dev endpoint is more consistent with the previous URL structure (/pull/new/master) and provides a cleaner, more direct interface for creating a pull request against the dev branch compared to the /compare/dev... syntax.

Suggested change
[Open a new pull request](https://github.com/firebase/firebase-admin-go/compare/dev...) and fill
[Open a new pull request](https://github.com/firebase/firebase-admin-go/pull/new/dev) and fill

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant