Repository navigation
chore: sync from GitLab (v1.8.7) - #196
Merged
Merged
Conversation
docs: remove FOSSA badge from README See merge request fireblocks/key-backup/recovery-utility!26
…ON-first share parsing
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix: strict PKCS#7 and UTF-8 passphrase for mobile share decryption See merge request fireblocks/key-backup/recovery-utility!28
tomer-shoham
requested review from
SlavaSereb
and
a balanced review from Copilot
October 8, 2026 16:18
There was a problem hiding this comment.
🟡 Changes recommended
The modified V2 decryption path lacks coverage for validation and passphrase-encoding behavior.
1 open finding
What changed in this PR
Improves mobile key-share decryption reliability and prepares recovery utility v1.8.7.
Changes:
- Enforces strict PKCS#7 padding and validates decrypted share shapes.
- Adds UTF-8 passphrase support with legacy Latin-1 fallback.
- Adds V1 tests, release metadata, and a patch changeset.
| File | Description |
|---|---|
packages/extended-key-recovery/src/decrypt.ts |
Uses Node.js crypto for strict decryption. |
packages/extended-key-recovery/src/mobileKey.ts |
Validates shares and supports passphrase encodings. |
packages/extended-key-recovery/tests/mobileKey.test.ts |
Adds V1 decryption regression tests. |
apps/recovery-utility/package.json |
Bumps version to 1.8.7. |
.changeset/strict-mobile-share-decrypt.md |
Documents the patch. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
SlavaSereb
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.