Repository navigation
bugfix/empty-table-spine - #53
Merged
Merged
Conversation
fivetran-catfritz
requested changes
Aug 10, 2026
| {% endset %} | ||
|
|
||
| {%- set first_date = dbt_utils.get_single_value(first_date_query) %} | ||
| {%- set first_date = dbt_utils.get_single_value(first_date_query) or '2024-01-01' %} |
Contributor
There was a problem hiding this comment.
This works, but I would use the method you used in Recharge on line 13. For consistency and that way you're not bound to 2024.
Contributor
Author
There was a problem hiding this comment.
Ah good call.
| [PR #53](https://github.com/fivetran/dbt_apple_store/pull/53) includes the following updates: | ||
|
|
||
| ## Bug Fix | ||
| - Fixes `int_apple_store__date_spine` compilation errors when the underlying sources are empty or contain no data. The model now falls back to a default start date of `2024-01-01` in this scenario. |
Contributor
There was a problem hiding this comment.
I suggest to synchronize the changelog message between Recharge and this PR.
…n/dbt_apple_store into bugfix/empty-table-spine
fivetran-avinash
left a comment
fivetran-avinash
left a comment
Contributor
Author
There was a problem hiding this comment.
@fivetran-catfritz ready for re-review!
| [PR #53](https://github.com/fivetran/dbt_apple_store/pull/53) includes the following updates: | ||
|
|
||
| ## Bug Fix | ||
| - Fixes `int_apple_store__date_spine` compilation errors when the underlying sources are empty or contain no data. The model now falls back to a default start date of `2024-01-01` in this scenario. |
| {% endset %} | ||
|
|
||
| {%- set first_date = dbt_utils.get_single_value(first_date_query) %} | ||
| {%- set first_date = dbt_utils.get_single_value(first_date_query) or '2024-01-01' %} |
Contributor
Author
There was a problem hiding this comment.
Ah good call.
fivetran-avinash
added
docs:ready
fivetran-catfritz
approved these changes
Aug 11, 2026
fivetran-catfritz
left a comment
fivetran-catfritz
left a comment
Contributor
There was a problem hiding this comment.
One additional adjustment but otherwise lgtm!
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
fivetran-avinash
added
docs:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog