Skip to content

bugfix/app-store-app-identifier - #54

Merged
fivetran-joemarkiewicz merged 5 commits into
mainfrom
bugfix/app-store-app-identifier
Aug 20, 2026
Merged

fivetran-joemarkiewicz merged 5 commits into
mainfrom
bugfix/app-store-app-identifier

Conversation

@fivetran-joemarkiewicz

Copy link
Copy Markdown
Collaborator

PR Overview

Package version introduced in this PR:

  • v1.3.3

This PR addresses the following Issue/Feature(s):

  • Internal reference

Summary of changes:

  • Prior to v1.3.0 the app_store_app identifier wasn't used to resolve the source table name. In v1.3.0 we introduced fivetran_utils.union_connections which does use the identifier to resolve the source name. However, the identifier for app_store_app didn't follow the expected naming conventions and referenced the app table instead of the app_store_app table it's intended to reference. This update fixes this issue.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • To validate I first ran the package code as of v1.2.0 and identifier the table selected from in the stg_apple_store__app_store_app_tmp model is in fact app_store_app. However, in v1.3.2 this source table is now app. Confirming this issue.
      • With these code changes I verified the correct app_store_app table is now being selected.
    • Testing Instructions: Confirm the change addresses the issue(s)
      • Follow the validation steps above to confirm the behavior and confirmation of the branch fixes the issue.
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Aug 20, 2026
@fivetran-joemarkiewicz fivetran-joemarkiewicz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Aug 20, 2026
@fivetran-joemarkiewicz
fivetran-joemarkiewicz enabled auto-merge (squash) August 20, 2026 16:02
@fivetran-joemarkiewicz
fivetran-joemarkiewicz merged commit e9237a7 into main Aug 20, 2026
12 checks passed
@fivetran-joemarkiewicz
fivetran-joemarkiewicz deleted the bugfix/app-store-app-identifier branch August 20, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants