Repository navigation
Include open tasks in asana__tag - #64
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #63
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
Removes
is_completedfrom thetaskCTE filter inasana__tag, leavingwhere tags is not null. Open tasks now reach the aggregation, sonumber_of_open_tasksandnumber_of_assigned_open_tasksare populated.number_of_tasks_completed,avg_days_openandavg_days_assignedalready filter onis_completedand are unchanged.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB with the integration test data. The stock seeds have no tagged open tasks, so I added one open, assigned task with 4 tags to
task_dataand tagged the existing completed task (seed change not included in this PR).sum(number_of_open_tasks)goes from 0 to 4 andsum(number_of_assigned_open_tasks)from 0 to 4.sum(number_of_tasks_completed)stays 1.dbt buildpasses on both the stock and modified seeds.