Repository navigation
Group daily events by mapped event subtype so schema changes are summed - #205
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #204
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
Changes the
group byin theagg_log_eventsCTE offivetran_platform__connection_daily_eventsfromevent_subtypeto thecaseexpression that maps schema change subtypes toschema_change. This restores the grouping thatgroup by 1,2,3had before PR #101, so all schema change events for a connection and day are summed into one row before the pivot.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB with the integration test data, plus three schema change rows added to a local copy of the
logseed (twocreate_table, onealter_table, same connection and day; not included in this PR).count_schema_changesfor that day goes from 2 to 3. Other counts are unchanged.dbt buildpasses.