Skip to content

Bugfix/missing parentsub exchangerate - #209

Merged
fivetran-jamie merged 5 commits into
release/1.8.0from
bugfix/missing-parentsub-exchangerate
Aug 26, 2026
Merged

fivetran-jamie merged 5 commits into
release/1.8.0from
bugfix/missing-parentsub-exchangerate

Conversation

@fivetran-joemarkiewicz

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • v1.8.0

This PR addresses the following Issue/Feature(s):

  • N/A

Summary of changes:

  • Updates the int_netsuite2__tran_with_converted_amounts model to apply the currency exchange rate of 1 when the attached subsidiary has no parent_id subsidiaries.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Aug 18, 2026
@fivetran-joemarkiewicz fivetran-joemarkiewicz added the pre-release Triggers the auto-releaser workflow. label Aug 18, 2026

@fivetran-catfritz fivetran-catfritz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question first, but approved for pre-release.

@fivetran-catfritz fivetran-catfritz added pre-release Triggers the auto-releaser workflow. and removed pre-release Triggers the auto-releaser workflow. labels Aug 18, 2026
@fivetran-jamie
fivetran-jamie changed the base branch from main to release/1.8.0 August 26, 2026 18:53
@fivetran-data-model-bot fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Aug 26, 2026
@fivetran-jamie
fivetran-jamie marked this pull request as ready for review August 26, 2026 18:54
@fivetran-jamie
fivetran-jamie merged commit 8229a4f into release/1.8.0 Aug 26, 2026
2 of 9 checks passed
fivetran-jamie added a commit that referenced this pull request Aug 31, 2026
* passthrough

* version

* consolidate branches

* 1.8.0

* inner join

* Bugfix/missing parentsub exchangerate (#209)

* bugfix/missing-parentsub-exchangerate

* changelog update

* Generate dbt docs via GitHub Actions

---------

Co-authored-by: fivetran-data-model-bot <fivetran-data-model-bot@users.noreply.github.com>
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

* revert

* Generate dbt docs via GitHub Actions

* seeeds

* no accounting book subsidiary

* Generate dbt docs via GitHub Actions

* catherine

* remove macro

* Generate dbt docs via GitHub Actions

---------

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: fivetran-data-model-bot <fivetran-data-model-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-release Triggers the auto-releaser workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants