Feature: Exchange rate addition by fivetran-avinash · Pull Request #223 · fivetran/dbt_quickbooks

fivetran-avinash · 2026-08-29T01:09:48Z

PR Overview

Package version introduced in this PR:

1.10.0

This PR addresses the following Issue/Feature(s):

GA-1032740

Summary of changes:

Bringing in exchange rate data, as well as additional variable support to grab the reporting date for the balance sheet and general ledger by period converted amounts.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

Resolves conflicts in dbt_project.yml/integration_tests/dbt_project.yml (kept 1.10.0), account_data.csv (combined both branches' new seed accounts), and CHANGELOG.md (kept newest-first order: 1.10.0, 1.9.2, 1.9.1).

Merge branch 'feature/exchange-rate' of https://github.com/fivetran/dbt_quickbooks into feature/exchange-rate

fivetran-jamie

Looks good, just some doc-related comments

…bt_quickbooks into feature/exchange-rate

fivetran-avinash

@fivetran-jamie Ready for re-review!

fivetran-jamie · 2026-09-14T18:31:58Z

    type: string
    value: ""
-    description: "The primary reporting currency, use the same 3-letter ISO currency code (e.g., USD, EUR, GBP, CAD) that appears in your QuickBooks `currency_id` field. Relevant for organizations with multiple currencies, this field defaults to an empty string; when not set, the package applies exchange rate conversions to all transactions, regardless of currency."
+    description: "The primary reporting currency, use the same 3-letter ISO currency code (e.g., USD, EUR, GBP, CAD) that appears in your QuickBooks `currency_id` field. Relevant for organizations with multiple currencies, this field defaults to an empty string; when not set, the package applies exchange rate conversions to all transactions, regardless of currency. Required if 'Enable Report-Date Balance Sheet FX Conversion' is enabled."


Suggested change

description: "The primary reporting currency, use the same 3-letter ISO currency code (e.g., USD, EUR, GBP, CAD) that appears in your QuickBooks `currency_id` field. Relevant for organizations with multiple currencies, this field defaults to an empty string; when not set, the package applies exchange rate conversions to all transactions, regardless of currency. Required if 'Enable Report-Date Balance Sheet FX Conversion' is enabled."

description: "The primary reporting currency, use the same 3-letter ISO currency code (e.g., USD, EUR, GBP, CAD) that appears in your QuickBooks `currency_id` field. Relevant for organizations with multiple currencies, this field defaults to an empty string; when not set, the package applies exchange rate conversions to all transactions, regardless of currency. Required if 'Enable Report-Date Balance Sheet FX Conversion' is true."

fivetran-jamie · 2026-09-14T18:35:42Z

+    {"name": "rate", "datatype": dbt.type_float()},
+    {"name": "created_at", "datatype": dbt.type_timestamp()},
+    {"name": "updated_at", "datatype": dbt.type_timestamp()},
+    {"name": "_fivetran_deleted", "datatype": "boolean"}


Suggested change

{"name": "_fivetran_deleted", "datatype": "boolean"}

{"name": "_fivetran_deleted", "datatype": dbt.type_boolean()}

fivetran-jamie · 2026-09-14T19:27:35Z

-        coalesce(period_ending_converted_balance_starter,
-            first_value(period_ending_converted_balance_starter) over (partition by gl_partition {{ fivetran_utils.partition_by_source_relation(package_name='quickbooks') }} 
-            order by period_last_day rows unbounded preceding)) as period_ending_converted_balance
+        period_beginning_converted_balance_final as period_beginning_converted_balance,


Claude suggests that this is using the legacy cumulative sum and needs to be updated to align with period_ending_converted_balance. Summary below:

Accounting identity breaks when report-date FX is enabled

In the final CTE, when using_report_date_fx_conversion: true:

period_ending_converted_balance = period_ending_balance_final * report_date_rate (report-date rate)

period_beginning_converted_balance = period_beginning_converted_balance_final (legacy cumulative transaction-date sum)

These use different methodologies in the same row. period_beginning[N+1] ≠ period_ending[N]. Any user computing net converted movement from these two columns gets a number that doesn't reconcile.

Fix: add a CTE that materializes period_ending_converted_balance, then derive period_beginning_converted_balance as lag() of it:

gl_report_date_converted as ( select *, case when report_date_rate is not null then period_ending_balance_final * report_date_rate else period_ending_converted_balance_legacy end as period_ending_converted_balance_final from gl_report_date_rate ), # Then in final: {% if report_date_fx_enabled %} lag(period_ending_converted_balance_final) over ( partition by account_id, source_relation, coalesce(class_id, '0') order by period_last_day ) as period_beginning_converted_balance, period_ending_converted_balance_final as period_ending_converted_balance {% else %} period_beginning_converted_balance_final as period_beginning_converted_balance, period_ending_converted_balance_legacy as period_ending_converted_balance {% endif %}

First-period lag() returning null is correct — no prior period exists.

Took the above suggestion and applied some changes to account for this, let me know your thoughts!

fivetran-jamie · 2026-09-14T19:29:03Z

@@ -1,3 +1,17 @@
+# dbt_quickbooks v1.10.0 (--full-refresh required when enabling `using_report_date_fx_conversion`)


I would move the full refresh note from the title

fivetran-avinash

@fivetran-jamie Ready for another look!

fivetran-jamie

LGTM! Two minor suggestions

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

fivetran-savage · 2026-09-16T20:20:40Z

@@ -1,3 +1,17 @@
+# dbt_quickbooks v1.10.0


Missing PR link

fivetran-savage · 2026-09-16T20:25:30Z

+
+If a matching exchange rate isn't available for an account's currency as of the period's last day, the package falls back to the legacy transaction-date summation method for that account and period.
+
+> IMPORTANT: If you enable `using_report_date_fx_conversion`, you need to run a `--full-refresh` for the change to take effect on historical data.


If users need to run a full refresh to get the conversion on historical data, we should call this out in the changelog.

Added it to the schema change section

fivetran-savage · 2026-09-16T20:28:07Z

+        description: Timestamp of the date which the exchange rate record was last updated.
+      - name: source_relation
+        description: "{{ doc('source_relation') }}"
+


Missing _fivetran_deleted

fivetran-avinash

@fivetran-savage Ready for re-review!

fivetran-avinash added 2 commits August 28, 2026 18:09

Feature: Exchange rate addition

f381ec1

Reseed for new test scenarios

e856a6f

fivetran-avinash self-assigned this Sep 2, 2026

Merge origin/main (1.9.2 AP/AR fanout fix) into feature/exchange-rate

d1e4da9

Resolves conflicts in dbt_project.yml/integration_tests/dbt_project.yml (kept 1.10.0), account_data.csv (combined both branches' new seed accounts), and CHANGELOG.md (kept newest-first order: 1.10.0, 1.9.2, 1.9.1).

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 2, 2026

fivetran-data-model-bot and others added 4 commits September 2, 2026 16:56

Generate dbt docs via GitHub Actions

eb648eb

Changelog/readme/quickstart.yml/test scenarios

b3670e4

:xi

e7a5c69

Merge branch 'feature/exchange-rate' of https://github.com/fivetran/dbt_quickbooks into feature/exchange-rate

quickstart var

805087b

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Sep 8, 2026

Generate dbt docs via GitHub Actions

83b3835

fivetran-jamie reviewed Sep 11, 2026

View reviewed changes

fivetran-avinash added 2 commits September 11, 2026 13:09

PR notes

0f3e8d4

Merge branch 'feature/exchange-rate' of https://github.com/fivetran/d…

62f0003

…bt_quickbooks into feature/exchange-rate

fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Sep 11, 2026

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 11, 2026

Generate dbt docs via GitHub Actions

1fd4331

fivetran-avinash commented Sep 11, 2026

View reviewed changes

fivetran-jamie reviewed Sep 14, 2026

View reviewed changes

PR review

366518d

fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Sep 15, 2026

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Sep 15, 2026

Generate dbt docs via GitHub Actions

2eeeb8e

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 15, 2026

Generate dbt docs via GitHub Actions

7ddb487

fivetran-avinash commented Sep 15, 2026

View reviewed changes

fivetran-jamie approved these changes Sep 15, 2026

View reviewed changes

Comment thread macros/get_report_date_fx_enabled.sql Outdated

Comment thread CHANGELOG.md Outdated

Apply batched suggestions from code review

196bc9a

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Sep 15, 2026

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 15, 2026

Generate dbt docs via GitHub Actions

fdf4354

fivetran-savage reviewed Sep 16, 2026

View reviewed changes

Release review

07b4b89

fivetran-data-model-bot removed the docs:ready Triggers the docs generator workflow. label Sep 16, 2026

fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Sep 16, 2026

fivetran-avinash commented Sep 16, 2026

View reviewed changes

Generate dbt docs via GitHub Actions

cfe62f7

fivetran-savage approved these changes Sep 16, 2026

View reviewed changes

fivetran-avinash merged commit 6b44f49 into main Sep 16, 2026
12 checks passed

	{"name": "_fivetran_deleted", "datatype": "boolean"}
	{"name": "_fivetran_deleted", "datatype": dbt.type_boolean()}

		@@ -1,3 +1,17 @@
		# dbt_quickbooks v1.10.0 (--full-refresh required when enabling `using_report_date_fx_conversion`)


		If a matching exchange rate isn't available for an account's currency as of the period's last day, the package falls back to the legacy transaction-date summation method for that account and period.

		> IMPORTANT: If you enable `using_report_date_fx_conversion`, you need to run a `--full-refresh` for the change to take effect on historical data.

Conversation

fivetran-avinash commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fivetran-avinash commented Aug 29, 2026 •

edited

Loading